Topic: Transportation priorities
|
nsh
Joined: 2010-11-08, 19:30
Posts: 27  Pry about Widelands |
Posted at: 2010-11-27, 11:29
I am working on request also. Unfortunately, that is not a single bug. Proposed their patch works as expected - it delays the ware allocation. But then the other bugs will surface - e.g. delayed requests are not proceeded later, until a new requests appear. And another problem is that production site issues all requests with the same current timestamp so that delaying is not possible - it asks all wares immediately. Until this two bugs fixed, fixing of request->get_priority() is not possible. Currently game resources allocation engine actually works due to the existence of this bug. 
Top
Quote
|
|
abtools
Joined: 2010-01-08, 15:31
Posts: 31 Pry about Widelands Location: Munich |
Posted at: 2010-11-30, 09:49
Hello nsh, I've created an additional patch that enables savegame support for your patch here: https://bugs.launchpad.net/widelands/+bug/681934 Maybe you can integrate it into your patch and fix the issues explained by Nicolai. Then your revised transport system should be ready. Best regards Andreas
Top
Quote
|
|
nsh
Joined: 2010-11-08, 19:30
Posts: 27 Pry about Widelands |
Posted at: 2010-11-30, 18:52
I am very thankful to you, Andreas! I looked very shortly at sources trying to find out how the load/save works, but didn't find it in the same files as data structures. And I was very lazy at the time to look further. Your patch on the patch Now I try to combine our efforts and produce something meeting developers' criteria Best regards, Shawkat
Top
Quote
|
|
abtools
Joined: 2010-01-08, 15:31
Posts: 31 Pry about Widelands Location: Munich |
Posted at: 2010-11-30, 19:55
Hello Shawkat, no problem, you're very welcome. Let me know if I can help you in any other way. It would be great if the ready transport system patch would be ready soon. I still think this is something very important that could make the gameplay much better. Best regards Andreas
Top
Quote
|
|
ixprefect
Joined: 2009-02-27, 13:28
Posts: 367  Tribe Member |
Posted at: 2010-11-30, 20:14
Yup... there's a long-term project to move the load/save functionality in the game logic classes themselves. All the Bobs and some other classes have already been converted, but the immovables (which include Flags) still use the old system, which is why the load/save support for them is in a completely different place.
Top
Quote
|
|
ixprefect
Joined: 2009-02-27, 13:28
Posts: 367 Tribe Member |
Posted at: 2010-12-01, 21:03
To keep those who don't watch Launchpad up to date: I've just committed nsh's patch + abtools fixes to trunk, so those who run development versions can try it out.
Top
Quote
|
|
abtools
Joined: 2010-01-08, 15:31
Posts: 31 Pry about Widelands Location: Munich |
Posted at: 2010-12-02, 09:43
Hello ixprefect, thanks for pushing the patch to trunk: I'll test it on the weekend. Best regards Andreas
Top
Quote
|
is really welcome!