Currently Online

Latest Posts

Topic: bzr7428 map editor bugs

einstein13
Avatar
Topic Opener
Joined: 2013-07-28, 23:01
Posts: 1118
Ranking
One Elder of Players
Location: Poland
Posted at: 2015-03-11, 00:22

Today I've tried current editor and I'm not very happy of that. Sorry.

Few bugs or features:

1) When opening the editor I can't load the map, I have to go to the editor, then go to the load-map window. Usually it is not useful, but when you are editing lots of existing maps it is hard to work with. It takes lots of time and clicking. I know that this "feature" has some time, but I used to "build-18 and before" user interface.

2) When I try to save the map in another directory than basic one I can create the directory, go into it, but I can't go outside! This bug exists for some time and I am sad that it isn't fixed at all face-sad.png

3) When you open exisitng map, edit it and try to save as the same name, you have a message: "Error Saving Map! Saved map file may be corrupt! ...". For me it sounds like "file=fopen(map_path)" and no "close(file)" in C code.

4) Old, unsolved bug: link to image. If you change the terrain type- resources and immovables still exists. So you can design a map where fishers will fish on the land and mines will dig in the water! Lets plant trees on lava face-smile.png

5 -not editor) Also I did lost few hours of my work, because I tried to open replay folder to choose a replay (through the Widleands!). Widleands got stuck and whole operatin system stopped (even a mouse coursor, what usually don't exists). I really don't know if is a Windows problem or Widelands problem. Did something changed with replays recently? I've tried to reproduce the problem, but I coudn't. The replay files opened just longer (going into the replay-browser in Widelands) than I expected. Instead of 0,5 sec I had to wait ~1,5 sec, but opened. The most problematic bugs are those where we can't reproduce them face-smile.png


einstein13
calculations & maps packages: http://wuatek.no-ip.org/~rak/widelands/
backup website files: http://kartezjusz.ddns.net/upload/widelands/

Top Quote
kaputtnik
Avatar
Joined: 2013-02-18, 19:48
Posts: 2441
OS: Archlinux
Version: current master
Ranking
One Elder of Players
Location: Germany
Posted at: 2015-03-11, 08:23

einstein13 wrote:

1) When opening the editor I can't load the map, I have to go to the editor, then go to the load-map window. Usually it is not useful, but when you are editing lots of existing maps it is hard to work with. It takes lots of time and clicking. I know that this "feature" has some time, but I used to "build-18 and before" user interface.

I don't like this behaviuor too. A workaround is to start widelands from a command line like

widelands --editor=/full/path/to/your/mapfolder/map.wmf

If you start widelands like this, the editor starts immediatly and loads the given map. Closing the editor closes widelands at all.

See this bug which brought the disableing of the menu on start.

2) When I try to save the map in another directory than basic one I can create the directory, go into it, but I can't go outside! This bug exists for some time and I am sad that it isn't fixed at all face-sad.png

Here on linux it works. If i create a new directory and go into it, the first item in the list is "<parent>". Doubleclicking on it will load the parent directory.

3) When you open exisitng map, edit it and try to save as the same name, you have a message: "Error Saving Map! Saved map file may be corrupt! ...". For me it sounds like "file=fopen(map_path)" and no "close(file)" in C code.

No problem here. See bug

4) Old, unsolved bug: link to image. If you change the terrain type- resources and immovables still exists. So you can design a map where fishers will fish on the land and mines will dig in the water! Lets plant trees on lava face-smile.png

See bug


Fight simulator for Widelands:
https://wide-fighter.netlify.app/

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 14:56
Posts: 3324
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2015-03-11, 08:44

1) I'm not sure I understand. Once you have started the editor, you can choose "Load Map" from the in-editor menu, no need to go back to anything else. Before, it was very cumbersome for new maps, because you had to create a blank new map before you could choose your map settings for the new map - this is the reason we changed it. The time you are waiting for the blank map when starting the editor is time you would be waiting anyway, because it is loading the Tribes etc. to initialize the editor. So, it might look as if you were losing time, but you're not.

2) has a bug report https://bugs.launchpad.net/widelands/+bug/1422147 Which was only opened fairly recently. I would be happy to take it on, but I can't build under Windows - this is a Windows only problem.

3) I get a prompt if I want to overwrite the file, and then it works. Maybe another Windows only problem?

4) Tibor is currently working on this https://bugs.launchpad.net/widelands/+bug/977980

5) This can get very slow when you have a lot of replays - maybe this was your issue?

ETA: Cross-posted with kaputtnik.

Edited: 2015-03-11, 08:56

Busy indexing nil values

Top Quote
einstein13
Avatar
Topic Opener
Joined: 2013-07-28, 23:01
Posts: 1118
Ranking
One Elder of Players
Location: Poland
Posted at: 2015-03-11, 10:01

@GunCheloc:

1) I know that in both ways we have to load whole editor, but still it is few more clicks to load a map.

Thanks for answers. Hope it will be fixed soon, because working like that makes lots of annoying issues face-smile.png

Ps.: Is there any fast way to find an exact bug? I've tried to find a bug via launchpad-search, but I failed to find a bug. It doesn't work well while finding something similar, not exact match. How do you find all the bugs-IDs? face-smile.png


einstein13
calculations & maps packages: http://wuatek.no-ip.org/~rak/widelands/
backup website files: http://kartezjusz.ddns.net/upload/widelands/

Top Quote
kaputtnik
Avatar
Joined: 2013-02-18, 19:48
Posts: 2441
OS: Archlinux
Version: current master
Ranking
One Elder of Players
Location: Germany
Posted at: 2015-03-11, 16:03

GunChleoc wrote:

1) ... Before, it was very cumbersome for new maps, because you had to create a blank new map before you could choose your map settings for the new map -

I am thinking about what is needed oftener: Creating a new map or load an existing map to edit this. For me (and probably for einstein13) the latter one is more used, than creating a new map. I never finished a map in one session...

einstein13 wrote:

Ps.: Is there any fast way to find an exact bug? I've tried to find a bug via launchpad-search, but I failed to find a bug. It doesn't work well while finding something similar, not exact match. How do you find all the bugs-IDs? face-smile.png

I use the "Tags" filter on the right side or/and the search box. You have to scroll trough the bugs in any way....


Fight simulator for Widelands:
https://wide-fighter.netlify.app/

Top Quote
Tibor

Joined: 2009-03-23, 22:24
Posts: 1377
Ranking
One Elder of Players
Location: Slovakia
Posted at: 2015-03-11, 18:27

Guys,

I just removed myself from assignement of bug https://bugs.launchpad.net/widelands/+bug/1422147.

I prepared some code, but in discussion they asked for more complex solution. And I am not familiar with editor's code, and I am tinkering more with AI, so I will not work it face-smile.png


Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 14:56
Posts: 3324
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2015-03-12, 14:31

Thanks for trying though face-smile.png

As to searching for bugs, tags are one option, or finding a good keyword to use for the search.


Busy indexing nil values

Top Quote
einstein13
Avatar
Topic Opener
Joined: 2013-07-28, 23:01
Posts: 1118
Ranking
One Elder of Players
Location: Poland
Posted at: 2015-03-12, 16:29

Ohhh... I've forgotten yesterday to make a feedback!

Me and Whytrytofly had problems during multiplayer game (tournament). The same as 5th issue. I was using Windows7, he- Linux (don't know the distribution).

There was no error message at all. Only break of whole window. For Windows it means no response for whole system. For linux - possible killing.

Also there were some small problems with fullscreen mode- for me it was working not too good during 3rd play (out of 4 starts!). Also it was a problematic when not everybody were connected to the server before game started.

Also I think that there is a problem when I open statistics window when not all players are connected. But this is only a guess- 1000 possibilities to make a bug then.

GunChleoc wrote:

or finding a good keyword to use for the search.

Hmm.... yes face-smile.png But I never find any good keyword! All I find is *** (nothing important) face-tongue.png


einstein13
calculations & maps packages: http://wuatek.no-ip.org/~rak/widelands/
backup website files: http://kartezjusz.ddns.net/upload/widelands/

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 14:56
Posts: 3324
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2015-03-12, 19:11

einstein13 wrote:

GunChleoc wrote:

or finding a good keyword to use for the search.

Hmm.... yes face-smile.png But I never find any good keyword! All I find is *** (nothing important) face-tongue.png

You could try making a blood sacrifice to the all-powerful Gods of Google face-tongue.png

I don't always find the bug I am looking for either, and then wl-zocker usually digs it up face-smile.png


Busy indexing nil values

Top Quote
wl-zocker

Joined: 2011-12-30, 16:37
Posts: 495
Ranking
Tribe Member
Location: Germany
Posted at: 2015-03-12, 19:57

I don't always find the bug I am looking for either, and then wl-zocker usually digs it up face-smile.png

Having been with Widelands for some years now helps to know what bugs we have and what their titles are (they sometimes emphasize a different aspect of the problem than that you are looking for). Furthermore, I have reported not a few bugs myself. If I know that, I can scroll through that relatively short list.

I also use the search funcion if I have no instant idea. Sometimes it works, sometimes it doesn't. I know from other fora I am not that familiar with that that can be difficult. kaputtnik has found the bugs, too. einstein13, in a few years, you will also be that good at finding bugs face-smile.png


"Only few people know how much one has to know in order to know how little one knows." - Werner Heisenberg

Top Quote