Currently Online

Latest Posts

Topic: Contributing

WorldSavior
Avatar
Joined: 2016-10-15, 04:10
Posts: 795
Ranking
One Elder of Players
Location: GER
Posted at: 2018-08-19, 20:08

Do we have further .lua-files which should be changed? And if we have them - is anyone here who would upload them to launchpad if I would send them?


“It's a threat to our planet to believe that someone else will save it.” - Robert Swan

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 2623
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2018-08-20, 09:49

I'd be happy to help with the upload again. The branch with your previous contribution is still being worked on: https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716

@hessenfarmer, would you like to manage this? You know much more about the balancing stuff than I do.


Busy indexing nil values

Top Quote
WorldSavior
Avatar
Joined: 2016-10-15, 04:10
Posts: 795
Ranking
One Elder of Players
Location: GER
Posted at: 2018-08-20, 18:07

GunChleoc wrote:

I'd be happy to help with the upload again.

Ok face-smile.png

The branch with your previous contribution is still being worked on: https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716

Could I help with reviewing there?


“It's a threat to our planet to believe that someone else will save it.” - Robert Swan

Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16
Posts: 429
Ranking
Tribe Member
Location: Bavaria
Posted at: 2018-08-20, 21:33

Definitly some Review would help. Especially the fix for the Last comments would be helpful


Top Quote
WorldSavior
Avatar
Joined: 2016-10-15, 04:10
Posts: 795
Ranking
One Elder of Players
Location: GER
Posted at: 2018-08-21, 01:22

hessenfarmer wrote:

Definitly some Review would help.

How should I do that?

Especially the fix for the Last comments would be helpful

What is that exactly?


“It's a threat to our planet to believe that someone else will save it.” - Robert Swan

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 15:56
Posts: 2623
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2018-08-21, 09:31

You can do 2 things for reviewing:

  1. Head over to https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716 and have a look at the diff and point out anything that looks wrong to you
  2. Get the last build for the branch from https://ci.appveyor.com/project/widelands-dev/widelands/history and test

Busy indexing nil values

Top Quote
WorldSavior
Avatar
Joined: 2016-10-15, 04:10
Posts: 795
Ranking
One Elder of Players
Location: GER
Posted at: 2018-08-21, 14:45

GunChleoc wrote:

You can do 2 things for reviewing:

  1. Head over to https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716 and have a look at the diff and point out anything that looks wrong to you

Let's see if I can complete that task...

  1. Get the last build for the branch from https://ci.appveyor.com/project/widelands-dev/widelands/history and test

Isn't appveyor something which doesn't work with linux? And it wouldn't be enough to download the data-file and test via the datadir-command, right?

Edited: 2018-08-21, 14:47

“It's a threat to our planet to believe that someone else will save it.” - Robert Swan

Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16
Posts: 429
Ranking
Tribe Member
Location: Bavaria
Posted at: 2018-08-21, 15:22

Testing with datadir option should be possible. Only the fix regarding the behaviour of depleted mines would need a compiled version. As far as I know you can pull a branch via Bazaar without being logged in on launchpad. Compiling in linux is easy if you can get the source code. Appveyor just provides us with windows builds


Top Quote
WorldSavior
Avatar
Joined: 2016-10-15, 04:10
Posts: 795
Ranking
One Elder of Players
Location: GER
Posted at: 2018-08-21, 22:18

hessenfarmer wrote:

Testing with datadir option should be possible. Only the fix regarding the behaviour of depleted mines would need a compiled version. As far as I know you can pull a branch via Bazaar without being logged in on launchpad. Compiling in linux is easy if you can get the source code. Appveyor just provides us with windows builds

Maybe it's easy for you, but not for me face-wink.png


“It's a threat to our planet to believe that someone else will save it.” - Robert Swan

Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16
Posts: 429
Ranking
Tribe Member
Location: Bavaria
Posted at: 2018-08-22, 08:54

WorldSavior wrote:

Maybe it's easy for you, but not for me face-wink.png

ok. I correct myself it is much easier than on windows. Perhaps you could try to follow this manual https://wl.widelands.org/wiki/Building%20Widelands/ and report if there isn't success.


Top Quote