""The Release Candidate is the ideal place to comment and criticize the work offered. That's after all what is meant by the word "candidate".""
Toptopple post is well intended, but incorrect. This is documented on our Releasing Widelands page. This quote fits for builds - comment, criticize constructively so the next build will be better. The release candidate is a baked version, only to test for critical bugs - i.e. game crashing bugs that have not been in the build prior. It is only about stability, not about features or non-crashing bugs. And while it seems minor to change something like starting logs, it is a untested change that might have unintended effects. It does not go into the release candidate - because it might break something and then we are stuck with the bug in production - probably for years.
This strictness comes from experience: We used to have less strict rules about build candidates and we broke a release because we did a last second image change. We replaced a menu icon - and this new particular PNG was somehow broken and some computers did not load it, but most did. A terrible pain - rolling back the release, rereleasing, updating all vendors again.
We made the rules stricter - but still allowed translations to be merged after release candidate. What happened? A string change that seemed unproblematic pulled in issues that made it impossible to even start Widelands in some locales - because the fresh new translations were using
% instead of
%%. We didn't notice, because these changes were not tested well enough.
That is the reason why we have 4 weeks of feature freeze. Because we decide what should go into the build - and what will be postponed. Once feature freeze is over the only reason for more commits in build 19 are crashes - nothing else should be touched to not endanger the stableness that was tested.
Build 20 will come - and all the feedback for b19 will instruct its design.
That's what i was thinking when i have launch the b19rc1.
""Now you are too late, now you must be silent!""
Yes, you are too late for feature for b19. You are not too late for b20 - DragonAtma for example gave a lot of good suggestions in here that will inform decisions for b20. You are invited to do the same - but there will be no functional changes to b19. With the release candidate - and 2 feature freezes of different strictness - behind us, it is too late for that.
That's what i will remember after posting about b19rc1.
You know, not saying "Thanks for the hard work. I have some suggestions", but instead "