Topic: B21 Encyclopedia bug-galore
stonerl Topic Opener |
Posted at: 2018-09-08, 14:37
I know that Build 20 isn't even out of the door, but IMHO one major focus for b21 should be on the Encyclopedia. It's a mess and it will be even messier when the mines-worldsavior branch gets merged. Here, a small incomplete list:
These are just some I recall out of my head and I'm pretty sure I'm missing many more. IMHO the Encyclopedia should be as accurate as possible since it is also the entry point for newcomers regarding information about tribes etc... Top Quote |
GunChleoc |
Posted at: 2018-09-08, 17:49
Will need a complete overhaul of the production program code. Since we are now using Lua instead of conf files for the definitions, production programs should be tree structures rather than a flat list. Also, we have 3 separate program parsers for Immovables, Bobs and Productionsites. Since we have recently unified the syntax of those 2 types of programs, there should only be 1 parser algorithm.
We have a forum thread for completing the Barbarian lore - I decided to postpone it, because translators are already very busy with 4 new scenarios and a new tribe.
That is probably a small bug somewhere - do you want to look into this for Build 20?
It says "... or better" in the building descriptions, so "Miner or better" means either a Miner, a Chief Miner or a Master Miner for the Barbarians. Or are you not talking about the building help? Busy indexing nil values Top Quote |
stonerl Topic Opener |
Posted at: 2018-09-08, 18:31
Here you mean the lua files for each production site?
I see. But wouldn't it be better to have displayed nothing at all? Instead of "Text needed" and "Source needed"... or something more imaginative. IDK, like, "A lore has yet to be written down by the elders." like "
Where does the encyclopedia gets the values from? Can you point me to the files?
I'm talking about the workers help. In the normal Miners help, all 3 types are listed for "Works at". Chief Miners have only Deep and Deeper mines and Master Miners has only Deeper. But this is more or less wrong. Since a Master Miner can also work in Deep and normal Mines. The same applies to the Chief-Miner. Top Quote |
hessenfarmer |
Posted at: 2018-09-08, 19:30
just had a quick look in the experience values they are documented where they sit in the lua files. +1 for having a better text for no lore yet defined. Perhaps a string like (can work in not already promoted buildings as well) could clarify the issue for experienced workers Top Quote |
stonerl Topic Opener |
Posted at: 2018-09-08, 20:07
It think pictures describe it better. Here the barbarians coalmine (everything is fine here): Here the barbarians deep coalmine: Here the deeper coalmine:
I was a little hasty here. +1 for a better text.
+1 Top Quote |
hessenfarmer |
Posted at: 2018-09-08, 21:47
ok the issue can be fixed easily in either way. the problem is that the first working position (is the least experienced worker) and the upgrade information of the last worker (most experienced) is delivered to the formatting script which results in the weird results. Top Quote |
hessenfarmer |
Posted at: 2018-09-08, 23:18
At least one issue solved: i found a solution for the mines in Mines-worldsavior branch. Top Quote |
GunChleoc |
Posted at: 2018-09-13, 06:55
I have created a bug: https://bugs.launchpad.net/widelands/+bug/1792297 Busy indexing nil values Top Quote |
GunChleoc |
Posted at: 2018-09-13, 06:58
I'd say the "Experience Levels" section needs to look just like for the basic mine for all 3 mines. So, follow the enhancement chain back down to the basic miner, then calculate from there. Busy indexing nil values Top Quote |
hessenfarmer |
Posted at: 2018-09-15, 17:08
Good news branch is uploaded. this fixes the last two bullet points Experience Levels are incorrect (Deep Mines) and or missing (Deeper Mines) Working Places are incorrect/wrong worded (Master Miners can work in all kinds of mines AFAIK) happy testing Top Quote |