Topic: Repairing mines
Arty
Joined: 2018-08-03, 11:14
Posts: 20  Pry about Widelands |
Posted at: 2018-08-16, 08:47
Oh, I see. Already taken care of. Nevermind then. 
Top
Quote
|
WorldSavior
Topic Opener
Joined: 2016-10-15, 03:10
Posts: 2094 OS: Linux Version: Recent tournament version  One Elder of Players Location: Germany |
Posted at: 2018-09-01, 17:36
Okay. I tested it now (trunk with datadir of the branch) and it didn't crash. I give "approve" for the branch even though I discovered a regression bug and another unexpected thing - imho it has higher priority to merge the branch than to change it again. The bug: If you press F1 in the game in order to show ware help and click on something which is produced by a mine - for example coal - it says "mine produces 1 coal" instead of "mine consumes 1 meal and produces 5 coal". I'm not surprised about that. The other unexpected thing: Miners don't get experience for every successful working "cycle", but basically for every produced ware. But is this really a bug? It could be also a feature. It is somehow logical that a miner gets more experience if he works together with a chief/master miner. And I think that it wouldn't be bad for the tribe balance, because every tribe which has to use deep mines seems to be disadvantaged in comparison to atlanteans, so it's not bad if miner training becomes simplified. Opinions about that? Wanted to save the world, then I got widetracked
Top
Quote
|
GunChleoc
Joined: 2013-10-07, 14:56
Posts: 3324 One Elder of Players Location: RenderedRect |
Posted at: 2018-09-01, 17:55
Thanks for testing! I think we should fix the in-game help before merging the branch, because the information is wrong now. Edited: 2018-09-01, 17:55
Busy indexing nil values
Top
Quote
|
|
WorldSavior
Topic Opener
Joined: 2016-10-15, 03:10
Posts: 2094 OS: Linux Version: Recent tournament version One Elder of Players Location: Germany |
Posted at: 2018-09-02, 23:29
You're welcome
Okay... But I think I cannot fix it without huge effort - because I expect this to be a C++ problem, not a Lua problem. So I don't volunteer for that Wanted to save the world, then I got widetracked
Top
Quote
|
|
WorldSavior
Topic Opener
Joined: 2016-10-15, 03:10
Posts: 2094 OS: Linux Version: Recent tournament version One Elder of Players Location: Germany |
Posted at: 2018-09-07, 14:13
Or you just replace hessenfarmer's files with my files? Wanted to save the world, then I got widetracked
Top
Quote
|
|
hessenfarmer
Joined: 2014-12-11, 22:16
Posts: 2650 One Elder of Players Location: Bavaria |
Posted at: 2018-09-07, 15:00
I am working on a solution to have the encyclopedia fixed. In fact it is not in the C++ Part. It is in tribes/scripting/help/ware_help.lua But even if I am unsuccessful I would prefer an issue in the Encyclopedia over issues in mines
Top
Quote
|
|
GunChleoc
Joined: 2013-10-07, 14:56
Posts: 3324 One Elder of Players Location: RenderedRect |
Posted at: 2018-09-08, 17:38
I have pushed a workaround for the encyclopedia. Busy indexing nil values
Top
Quote
|
|
hessenfarmer
Joined: 2014-12-11, 22:16
Posts: 2650 One Elder of Players Location: Bavaria |
Posted at: 2018-09-08, 23:19
I have pushed a workaraound solution for the encyclopedia.
Top
Quote
|
|
WorldSavior
Topic Opener
Joined: 2016-10-15, 03:10
Posts: 2094 OS: Linux Version: Recent tournament version One Elder of Players Location: Germany |
Posted at: 2018-09-10, 18:14
That's good Wanted to save the world, then I got widetracked
Top
Quote
|
|
hessenfarmer
Joined: 2014-12-11, 22:16
Posts: 2650 One Elder of Players Location: Bavaria |
Posted at: 2018-09-12, 21:58
this branch finally hit trunk.
Top
Quote
|
